Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2.4: change(pivot2pgr): do not use clean_graph() procedure #75

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

azarz
Copy link
Member

@azarz azarz commented Feb 27, 2024

Using a SQL query instead of the clean_graph() procedure in the pivot2pgr script seems to be more efficient.
The SQL query does the same thing as the procedure, and is slightly different due to the difference between syntaxes.

@azarz azarz requested review from lgrd and jmkerloch February 27, 2024 09:47
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1052 402 38% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
r2gg/about.py 100% 🟢
r2gg/_pivot_to_pgr.py 4% 🟢
TOTAL 52% 🟢

updated for commit: 008a5e3 by action🐍

Copy link
Contributor

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azarz azarz merged commit 884235e into master Mar 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants